Hello Guest

[CLOSED] rename opengles jars to prevent name collision overwrite

  • 4 Replies
  • 4654 Views
For users who build both opengl and opengl-es find that the opengl-es build have overwritten the lwjgl.jar in libs see below:

-createjars:
[lwjgl.jar] Building jar: /media/go_/LWJGL-svn/temp/jar/lwjgl.jar
[lwjgl_util_applet.jar] Building jar: /media/go_/LWJGL-svn/temp/jar/lwjgl_util_applet.jar
[lwjgl_test.jar] Building jar: /media/go_/LWJGL-svn/temp/jar/lwjgl_test.jar
[lwjgl_util.jar] Building jar: /media/go_/LWJGL-svn/temp/jar/lwjgl_util.jar

jars:

-jars_NoDEP:
     [ move] Moving 4 files to /media/go_/LWJGL-svn/libs

-createjars_es:
   [delete] Deleting: /media/go_/LWJGL-svn/null1625701105
[lwjgl.jar] Building jar: /media/go_/LWJGL-svn/temp/jar/lwjgl.jar
[lwjgl_test.jar] Building jar: /media/go_/LWJGL-svn/temp/jar/lwjgl_test.jar

jars_es:

-jars_NoDEP:
     [ move] Moving 2 files to /media/go_/LWJGL-svn/libs

ouch...
The attached patch fix by adding es to all the es specific jars!

« Last Edit: October 13, 2011, 23:36:22 by xranby »

*

Offline Matzon

  • *****
  • 2242
Re: [BUG/RFE] rename opengles jars to prevent name collision overwrite
« Reply #1 on: October 14, 2011, 06:15:51 »
hmm, although very valid - I am not sure what we want to do here - in the long term run ...
perhaps we should create an -es specific jar that contains just those parts.

*

Offline spasi

  • *****
  • 2198
    • WebHotelier
Re: [BUG/RFE] rename opengles jars to prevent name collision overwrite
« Reply #2 on: October 14, 2011, 10:12:02 »
If we rename the output jar, then it makes sense to also rename the output native libs. Those are overwritten as well when you do a compile_native_es. I haven't done that because Sys depends on the file name being lwjgl.dll/so/etc. Besides, if you need to build normal LWJGL locally, then you're developing something in the library, which means you know what you're doing and it's no big deal.

We should reconsider this in LWJGL 3.0 imho.

Re: [BUG/RFE] rename opengles jars to prevent name collision overwrite
« Reply #3 on: October 14, 2011, 10:42:58 »
If we rename the output jar, then it makes sense to also rename the output native libs. Those are overwritten as well when you do a compile_native_es. I haven't done that because Sys depends on the file name being lwjgl.dll/so/etc. Besides, if you need to build normal LWJGL locally, then you're developing something in the library, which means you know what you're doing and it's no big deal.

We should reconsider this in LWJGL 3.0 imho.

im quite happy that the native lib have the same name, they do get put into separate dirs under the bin directory so both versions are preserved so i dont see the bug here for native libs.
bin/lwjgl/liblwjgl.so
and
bin/lwjgles/liblwjgl.so

« Last Edit: October 14, 2011, 10:45:03 by xranby »

*

Offline spasi

  • *****
  • 2198
    • WebHotelier
Re: [BUG/RFE] rename opengles jars to prevent name collision overwrite
« Reply #4 on: October 14, 2011, 10:57:12 »
They're also copied to ${lwjgl.lib}/<platform>.