Hello Guest

[FIXED] Duplicate GL_BGRA

  • 3 Replies
  • 8243 Views
*

Offline ra4king

  • **
  • 58
  • I'm the King!
    • Roi's Website
[FIXED] Duplicate GL_BGRA
« on: September 01, 2012, 20:35:52 »
GL12 and GL32 both have a GL_BGRA constant with the same value. Fix is to simply remove GL_BGRA from GL32

This bug was found by theagentd, so credit goes to him again :)

Note: since this is the second time we found a duplicate variable, there really should be a test case that checks for duplicates :S

EDIT: GL_BGRA is also found in ARBVertexArrayBgra, but it's the only thing there. What should be done about that?
« Last Edit: September 01, 2012, 21:08:47 by ra4king »
-Roi

*

Offline spasi

  • *****
  • 2261
    • WebHotelier
Re: [BUG] Duplicate GL_BGRA
« Reply #1 on: September 03, 2012, 20:27:25 »
Fixed.

*

Offline ra4king

  • **
  • 58
  • I'm the King!
    • Roi's Website
Re: [BUG] Duplicate GL_BGRA
« Reply #2 on: September 03, 2012, 20:29:07 »
Sweet, I just saw the commit, thanks!

What did you do about ARBVertexArrayBgra?
-Roi

*

Offline spasi

  • *****
  • 2261
    • WebHotelier
Re: [FIXED] Duplicate GL_BGRA
« Reply #3 on: September 04, 2012, 11:19:44 »
The extension spec says:

Quote
This extension is written against the OpenGL 2.1 Specification but can apply to OpenGL 1.1 and up.

Since GL_BGRA is in GL core from 1.2+ and the extension could (in theory) be available with an 1.1 implementation, I didn't change ARB_vertex_array_bgra.