[FIXED] Duplicate GL_BGRA

Started by ra4king, September 01, 2012, 20:35:52

Previous topic - Next topic

ra4king

GL12 and GL32 both have a GL_BGRA constant with the same value. Fix is to simply remove GL_BGRA from GL32

This bug was found by theagentd, so credit goes to him again :)

Note: since this is the second time we found a duplicate variable, there really should be a test case that checks for duplicates :S

EDIT: GL_BGRA is also found in ARBVertexArrayBgra, but it's the only thing there. What should be done about that?
-Roi

spasi


ra4king

Sweet, I just saw the commit, thanks!

What did you do about ARBVertexArrayBgra?
-Roi

spasi

The extension spec says:

QuoteThis extension is written against the OpenGL 2.1 Specification but can apply to OpenGL 1.1 and up.

Since GL_BGRA is in GL core from 1.2+ and the extension could (in theory) be available with an 1.1 implementation, I didn't change ARB_vertex_array_bgra.